Fix fake-cucumber and the compatibility kit with pending steps #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
davidjgoss
approved these changes
Sep 13, 2021
aurelien-reeves
deleted the
fix-fake-cucumber-success-with-pending-steps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The "pending" feature says that cucumber execution should fail with pending steps, but the resulting ndjson in the CCK was "success: true".
Details
Fix fake-cucumber to fail whith pending step, and regenerate a proper ndjson for the compatibility kit
Motivation and Context
The CCK validation of cucumber-js is failing because of that issue
How Has This Been Tested?
the resulting ndjson is validating the update of fake-cucumber
Screenshots (if appropriate):
Types of changes
Checklist: