Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tag-expressions] Fix Perl handling of backslash escaping in tags #1785

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

ehuelsmann
Copy link
Contributor

Summary

The escaping backslash was added to the tag and if the escaped character
was a space, it was skipped even though being escaped.

Motivation and Context

Review of the Perl implementation triggered by #1778.

How Has This Been Tested?

More unit tests have been added.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • The change has been ported to Java.
  • The change has been ported to Ruby.
  • The change has been ported to JavaScript.
  • The change has been ported to Go.
  • The change has been ported to .NET.
  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG accordingly.

Adding to CHANGELOG not necessary: the Perl implementation hasn't been released yet.

The escaping backslash was added to the tag and if the escaped character
was a space, it was skipped even though being escaped.

Re #1778.
@ehuelsmann ehuelsmann enabled auto-merge (squash) October 8, 2021 12:55
@ehuelsmann ehuelsmann merged commit d1b54d4 into main Oct 8, 2021
@ehuelsmann ehuelsmann deleted the backslash-tag-expressions branch October 8, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant