Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Feature to Gherkin topic #32

Closed
wants to merge 1 commit into from
Closed

Add Feature to Gherkin topic #32

wants to merge 1 commit into from

Conversation

belgoros
Copy link

@belgoros belgoros commented Jul 4, 2016

  • create gherkin.md
  • add feature introduction section
  • add step definitions section

* create gherkin.md
* add feature introduction section
* add step definitions section
@mattwynne
Copy link
Member

Thanks @javix - dd you write this from scratch or pull it from somewhere else? I have the feeling I've read some of this before.

@belgoros
Copy link
Author

belgoros commented Jul 5, 2016

Sure, I've taken it from the old wiki https://github.com/cucumber/cucumber/wiki


Gherkin serves two purposes — documentation and automated tests. The third is a bonus feature — when it yells in red it’s talking to you, telling you what code you should write.

Gherkin’s grammar is defined in the Treetop grammar that is part of the Cucumber codebase. The grammar exists in different flavours for many spoken languages (37 at the time of writing), so that your team can use the keywords in your own language.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty technical for an introduction. I think all we should mention is that a lot of spoken languages (much more than 37 nowadays I believe) are supported. Keeping the part about why this matters (i.e. use the language of your team/project) is good though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also out of date - we haven't used Treetop for several years now.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattwynne the Treetop mention has been removed in #34.

This was referenced Jul 6, 2016
aslakhellesoy added a commit that referenced this pull request Jul 13, 2016
@mattwynne
Copy link
Member

Not your fault @javix but I think this content is pretty crap. It's over-technical and doesn't provide a simple, accessible introduction to Gherkin and how to use it.

I think we need to avoid lifting content as-is from the old wiki - we need to do some quality checking as we do.

@belgoros
Copy link
Author

@mattwynne sure, I'll try to do my best. I feel like an author preparing his book and who has to apply corrections provided by his editor, all that will always give the best result for the future readers 😄

@mattwynne
Copy link
Member

I know it must be tiring @javix and thanks for your patience. I think we'll soon build some momentum and things will feel more satisfying for you.

@belgoros
Copy link
Author

@mattwynne no worries, this is my real first experience of writing docs, especially for the tool I love. So I'm patient and shall absorb everything to enlarge my Xperience 😄

@aslakhellesoy
Copy link
Contributor

This is obsolete - superseded by #34

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants