Skip to content

Commit

Permalink
fix: re-add arguments support, correct retry sample (#18)
Browse files Browse the repository at this point in the history
* add readme note about jq

* unused import

* move current logic into a js file

* load and prepend arguments

* remove old file

* regenerate retry.feature.ndjson

* update CHANGELOG.md

* add readme note about arguments
  • Loading branch information
davidjgoss authored Jul 11, 2022
1 parent 985e507 commit fbfe5b2
Show file tree
Hide file tree
Showing 9 changed files with 558 additions and 69 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

* `body` was sometime missing in `attachments.feature.ndjson`
([PR#17](https://github.com/cucumber/compatibility-kit/pull/17/))
* Fix messages for `retry.feature.ndjson` to include multiple attempts ([#18](https://github.com/cucumber/compatibility-kit/pull/18))

## [11.0.0] - 2022-06-28

Expand Down
8 changes: 0 additions & 8 deletions devkit/.ci_env

This file was deleted.

4 changes: 4 additions & 0 deletions devkit/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ To add a new feature in the kit, create a new folder in [`samples`](./samples).
Put the feature here, and its step definitions implemented in TypeScript, and
any required assets like pictures that would be used as attachements for example.

If you need to provide extra arguments to fake-cucumber for your suite, you can add a `{name}.arguments.txt` file to the directory too - see [the retry suite](./samples/retry/retry.arguments.txt) for an example.

Once your feature is ready, you can generate the messages.

### Generating the Messages
Expand All @@ -43,6 +45,8 @@ in the packages.
After reviewing the `git diff`, you can commit and push the changes into a new
pull request for review.

Note: You need to have `jq` available on your path.

#### Note regarding the packages

The packages have specific instructions into `.gitignore` to ignore the files
Expand Down
Loading

0 comments on commit fbfe5b2

Please sign in to comment.