Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby: Introduce rubocop #49

Merged
merged 18 commits into from
Oct 5, 2023
Merged

Ruby: Introduce rubocop #49

merged 18 commits into from
Oct 5, 2023

Conversation

luke-hill
Copy link
Contributor

🤔 What's changed?

Introduce rubocop - Fix a few simple AF cops

⚡️ What's your motivation?

Get full ruby suite code-clean

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

This won't run in CI @davidjgoss. This is purely a dev only change as by the time we make this vaguely compliant we'll likely be moving the code over to the other repo

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@luke-hill luke-hill merged commit f065f70 into main Oct 5, 2023
@luke-hill luke-hill deleted the refactor/introduce_rubocop branch October 5, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant