Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CCK] 2x Attachment bugfixes: Upload JPEG + PDF rename #52

Merged
merged 10 commits into from
Oct 9, 2023
Merged

[CCK] 2x Attachment bugfixes: Upload JPEG + PDF rename #52

merged 10 commits into from
Oct 9, 2023

Conversation

luke-hill
Copy link
Contributor

@luke-hill luke-hill commented Oct 5, 2023 •
edited
Loading

🤔 What's changed?

Fixes 2 x CCK inconsistencies wrt name vs actions

  • Upload and attach a JPEG should attach a JPEG (Currently tests vs a PNG)
  • Attach and rename a PDF (Doesn't actually rename the PDF)

⚡️ What's your motivation?

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

First time I've made changes to the NDJSON / CCK spec

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@luke-hill luke-hill marked this pull request as ready for review October 5, 2023 12:32
@luke-hill luke-hill changed the title Draft: 2x bugfix: CCK Upload inconsistency + PDF rename [CCK] 2x Attachment bugfixes: Upload JPEG + PDF rename Oct 5, 2023
@luke-hill luke-hill requested a review from davidjgoss October 5, 2023 13:34
@luke-hill
Copy link
Contributor Author

This is now RtM I believe

@luke-hill luke-hill mentioned this pull request Oct 6, 2023
Open
davidjgoss
davidjgoss approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@davidjgoss davidjgoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wants to be a major release.

@luke-hill luke-hill merged commit b49f528 into main Oct 9, 2023
@luke-hill luke-hill deleted the bugfix/46-cck-actions branch October 9, 2023 12:58
@luke-hill luke-hill mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidjgoss davidjgoss davidjgoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luke-hill @davidjgoss