Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] bugfix: Don't check git sub-messages #66

Merged
merged 8 commits into from
Oct 10, 2023

Conversation

luke-hill
Copy link
Contributor

🤔 What's changed?

Fix a situation where we were incorrectly checking Ci messages
Don't check Git message properties, as these can vary (The NDJSON generation won't have a branch, but every CI run will have a branch)

⚡️ What's your motivation?

Get cucumber-ruby conformant

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@luke-hill luke-hill merged commit f301fd4 into main Oct 10, 2023
@luke-hill luke-hill deleted the bugfix/dont_check_git_submessages branch October 10, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant