-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #204. Go to step definition from a feature file with CTRL+click #290
Conversation
This is really good! 👍 Just wondering, why should it not work with RegularExpresions? AFAIK the CucumberExpresionParser used also support the old style regular Expresions? |
@laeubi I misspoke. This works with regular expressions and cucumber expressions. However for this last, only cucumber expressions with built-in parameter types works, for example Because of a limitation in the step parser during the step definitions detection. This one use the Snippet from this.expression = new ExpressionFactory(new ParameterTypeRegistry(locale)).createExpression(text); In order to support custom parameter type, the plugin should retrieve all Thus, #285 and #290 will support the cucumber expressions with custom parameter type. |
Oooops, I am just seeing that I did not push my branch on my fork... |
a4b4204
to
e1bfdb8
Compare
Wiki updated @girijant |
@girijant could you update the Eclipse MarketPlace description to remove the following parenthis please ?
To have just
Thank you |
Hello,
This PR allows to use CTRL+click on a step to jump into its definition, as F3. (#204)
Known limitation
As #285, only built-in cucumber expressions (with built-in parameter types, or with regular expressions) are supported. The plugin lacks
ParameterType
detection for now.An other example with lambdas