Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractTestNGCucumberTests does not tear down test in case TestNG groups a set #955

Closed
sventorben opened this issue Jan 22, 2016 · 1 comment
Closed

AbstractTestNGCucumberTests does not tear down test in case TestNG groups a set #955

sventorben opened this issue Jan 22, 2016 · 1 comment

Comments

@sventorben
Copy link
Contributor

To execute cucumber tests with AbstractTestNGCucumberTests a group named "cucumber" must be set.
When setting a group, TestNG only executes methods annotated with that group or having thhe alwaysRun-attribute set to true.

Within AbstractTestNGCucumberTests there are two configuration methods, namely setUpClass and tearDownClass. Only setUpClass is annotated with alwaysRun=true, but tearDownClass is not.
This means that tearDownClass will never be executed when cucumber tests are executed, because the group "cucumber" is set.

The behaviour of the two configuration methods is inconsistent and should be unified.
sventorben added a commit to sventorben/cucumber-jvm that referenced this issue Jan 22, 2016
@sventorben
Always tears down TestNG cucumber tests.
8066aa6 
This ensures that TestNGCucumberRunner.finish() will always be invoked.

Fixes cucumber#955
@sventorben sventorben mentioned this issue Jan 22, 2016
Merged
sventorben added a commit to sventorben/cucumber-jvm that referenced this issue Jan 24, 2016
@sventorben
Always tears down TestNG cucumber tests.
a94ebb4 
This ensures that TestNGCucumberRunner.finish() will always be invoked.

Fixes cucumber#955
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sventorben