Use gherkin4 review nitpicks #1131
Conversation
mpkorstanje
force-pushed
the
use-gherkin4-nitpicks
branch
3 times, most recently
from
ae9c8d3 to
f71237b
Compare
|
@aslakhellesoy and @mattwynne build is green again except for open-jdk-7. Reverted making Match package private. This made JSONFormatterTest fail because mockito was no longer able to mock on the remote server. Unsure why it works locally. Also removed the fix for the EnumResult status because this will be properly solved in #1133. |
TestNGCucumberRunner needs to be public for the use cases when the runner class need to inherit from another base class than AbstractTestNGCucumberTests.
brasmusson
force-pushed
the
use-gherkin4-nitpicks
branch
from
7a2aff0 to
94d507d
Compare
|
The class TestNGCucumberRunner needs to be public for the use cases where the runner class does not inherit from AbstractTestNGCucumberTests, see https://github.com/cucumber/cucumber-jvm/tree/master/examples/java-calculator-testng. I have fixed that. |
Squashed commit of the following: commit 94d507d Author: Björn Rasmusson <[email protected]> Date: Fri May 26 11:16:53 2017 +0200 [TestNG] Revert TestNGCucumberRunner to be public. TestNGCucumberRunner needs to be public for the use cases when the runner class need to inherit from another base class than AbstractTestNGCucumberTests. commit 458f139 Author: mpkorstanje <[email protected]> Date: Mon May 22 22:08:18 2017 +0200 [TestNG] Updated testng for the use of Gherkin v4.0.0. -- nitpicks commit 95569a2 Author: mpkorstanje <[email protected]> Date: Mon May 22 22:02:37 2017 +0200 [TestNG] Updated testng for the use of Gherkin v4.0.0. -- nitpicks commit 7141152 Author: mpkorstanje <[email protected]> Date: Wed May 17 23:35:24 2017 +0200 [Core] Updated core for the use of Gherkin v4.0.0. -- review nitpicks commit efc05db Author: mpkorstanje <[email protected]> Date: Wed May 17 23:34:53 2017 +0200 [Junit] update to Gherkin5. -- review nit picks commit 90cb9e5 Author: mpkorstanje <[email protected]> Date: Sat May 13 22:32:23 2017 +0200 [Junit] update to Gherkin5. -- review nit picks
|
Merged in ac1b214. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Lets try #1122 again.