Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print JUnit Options when unknown option is provided #1273

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Print JUnit Options when unknown option is provided #1273

merged 1 commit into from
Oct 26, 2017

Conversation

mlvandijk
Copy link
Member

Summary

Print available JUnit Options when an unknown option is provided

Details

Only a few JUnit options can be provided in the command line arguments or the CucumberOptions. For any other options a CucumberException is thrown stating that an "Unknown option" is used.

Motivation and Context

Found while testing PR for #147

How Has This Been Tested?

Running cucumber-java-skeleton project with all known and several unknown options.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 81.289% when pulling c02203c on mlvandijk:junit-options into 72f975a on cucumber:master.

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Oct 26, 2017

This is not needed when cucumber is ran from the commandline. The commandline won't use junit. But I guess this makes sense when mvn test "-Dcucumber.options --junit,--no-allow-started-ignored" is used.

@mpkorstanje mpkorstanje merged commit e32dcdb into cucumber:master Oct 26, 2017
@mlvandijk mlvandijk deleted the junit-options branch June 28, 2018 11:25
@lock
Copy link

lock bot commented Jun 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants