[Core] Set scenario result as step finishes #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The results of a step were set on the scenario after a test step finished. This meant that the result of the step was not available in its after hooks. By adding the result of the step to the scenario in TestStep we ensure that scenario always contains the most recent result. This removes the need to pass the scenario results around. Additionally: * Scenario has moved from cucumber.runtime.ScenarioImpl to cucumber.runner.Scenario and made package private. This prevents the implementation being used outside of the API. Users of ScenarioImpl.getError should use an event listener to create their reports. * TestStep.run no longer requires a language parameter. With Gherkin v5 the language is not used anywhere.
mpkorstanje
changed the title
mpkorstanje
changed the title
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The results of a step were set on the scenario after a test step
finished. This meant that the result of the step was not available in
its after hooks.
By adding the result of the step to the scenario in TestStep we ensure
that scenario always contains the most recent result. This removes the
need to pass the scenario results around.
Additionally:
Scenario has moved from cucumber.runtime.ScenarioImpl to
cucumber.runner.Scenario and made package private. This prevents the
implementation being used outside of the API. Users of
ScenarioImpl.getError should use an event listener to create their
reports.
TestStep.run no longer requires a language parameter. With Gherkin v5
the language is not used anywhere.
Fixes #1429
Fixes #1427