[Core] Parse rerun file in RuntimeOptions #1529
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cucumber runs features on the feature path. The feature path can consist
of features, features with line filters or a rerun file containing
features with line filters.
The current implementation would pass the rerun file inwards as if
it were another feature file. The FeatureLoader would then deal with it.
This behavior is undesirable for two reasons:
files.
runners have different methods to rerun their own tests. As such it
should be contained in RuntimeOptions and not leak into other parts
of the core.
Moving rerun file parsing into CucumberOptions now allows the following
to be done:
GherkinFeature into pickles in a single FeatureParser that now
produces a ready to use CucumberFeature object.
features.
JUnit and TestNG runner.
Additionally we can now emit a proper error when a feature file is explicitly referenced but does not exist i.e:
Types of changes
Checklist: