[Core] Fix filtering scenarios loaded from jar

[derwasp]

Summary

Don't add an extra slash after the classpath: scheme

Details

Changed the ZipResource to preserve the original path of the zipped entity.

Motivation and Context

I am running cucumber tests with features loaded from classpath:, like this:

java -cp fatjar.jar cucumber.api.cli.Main "classpath:features/FeatureWithExamples.feature:64"

However, when cucumber parses this path and creates a ZipResource from it, it adds an extra slash:

And the url becomes classpath:/features/FeatureWithExamples.feature:64

This becomes a problem down the line, when LinePredicate tries to filter out the pickles:

This if does't pass (because the key is not the one in the map) and instead of filtering the pickles out, it just lets all of the though the filter.

I tried changing the path to be classpath:/features/FeatureWithExamples.feature:64 right away. But then the loader is unable to get the resource:

Can you please tell me whether this change makes sense or am I confusing things here?

Types of changes

• Bug fix (non-breaking change which fixes an issue).
• New feature (non-breaking change which adds functionality).
• Breaking change (fix or feature that would cause existing functionality to not work as expected).

[coveralls]

Coverage remained the same at 86.116% when pulling 6b46ef3 on derwasp:feature/support-classpath-for-features into 437bb3a on cucumber:master.

[derwasp]

Seems like it's related to #1544 by @mpkorstanje

[aslakhellesoy]

Hi @derwasp,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
• 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

[mpkorstanje]

Cheers!

[mpkorstanje]

@derwasp should be a new version available in a few hours.

[derwasp]

@mpkorstanje thank you for the rocket-fast release!

[mpkorstanje]

No problem. Would you mind commenting on:

cucumber/common#568

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.