Reduce pretty formatter output flushes for DataTables (#2536) #2537
Conversation
There was a problem hiding this comment.
While this solution reduces the number of flushes, it tries to solve a problem that happens several abstractions down. As a result the problem is not solved fundamentally and will re-occur whenever a flush does not coincide with a newline.
Please consider all my comments from #2481 to develop your solution.
| // Gradle adds a newline for every call to flush() unless the most | ||
| // recent character written was already a newline. That leads | ||
| // to some VERY difficult to read tables on the console. | ||
| StringBuilder buffer = new StringBuilder(); |
There was a problem hiding this comment.
Normally it could be assumed that the Appendable is well behaved. However for the formatter we know that lines may interleave with other output as it writes to System.out. Consider pushing this buffer up to the pretty formatter instead.
There was a problem hiding this comment.
Pushed the buffer up to the pretty formatter by commit f4a2d42 . Only caveat - I can't decide how to test that particular change or whether a unit test is warranted.
|
mpkorstanje, I created a separate pull request #2541, which might be more acceptable as a general-purpose solution. Could you take a look at that one? If you prefer the other solution, feel free to close this one. Either of them solves my display problem. |
|
Superseded by #2481 |
🤔 What's changed?
See details in #2536 and #2481
⚡️ What's your motivation?
DataTables were formatted incorrectly by the Pretty formatter when using Gradle.
🏷️ What kind of change is this?
The problem stemmed from the fact that Gradle adds a newline with every flush of the output stream, and cucumber-jvm was flushing the output stream very frequently. For DataTables, it was flushing with every cell, padding, and delimiter. This caused an unreadable output. It also reduces I/O performance by flushing excessively.
♻️ Anything particular you want feedback on?
Make sure it follows project standards.
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.