Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JUnit Platform Engine] Set Engine-Version-cucumber attribute #2963

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

mpkorstanje
Copy link
Contributor

🤔 What's changed?

By setting the Engine-Version-cucumber attribute to the current version TestEngine.getVersion will return the correct version instead of development.

⚡️ What's your motivation?

Fixes: ##2936

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mpkorstanje mpkorstanje force-pushed the fix-cucumber-engine-get-version branch from bedd9d5 to 63d349a Compare January 16, 2025 15:07
By setting the Engine-Version-cucumber attribute to the current version
TestEngine.getVersion will return the correct version instead of
development.

Fixes: ##2936
@mpkorstanje mpkorstanje force-pushed the fix-cucumber-engine-get-version branch from 63d349a to 0e6d3e6 Compare January 16, 2025 15:07
@mpkorstanje mpkorstanje merged commit 8b588ca into main Jan 16, 2025
6 checks passed
@mpkorstanje mpkorstanje deleted the fix-cucumber-engine-get-version branch January 16, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant