Got rid of Maven Shade Plugin wherever it was possible. #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artefacts which still have need to use the plugin:
- cucumber-groovy
- cucumber-jython
- cucumber-jruby
This was referenced Jun 8, 2013
|
Looks good to me, all tests pass, and this makes sense. I'll annotate it in the history on the commit after this. |
dkowis
added a commit
that referenced
this pull request
Jun 9, 2013
Got rid of Maven Shade Plugin wherever it was possible.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Artefacts which still have need to use the plugin:
The PR is related to #518 and #520 issues.
Also, the
cucumber-coreartefact can't be used as standalone jar at the moment because of thejava.lang.NoClassDefFoundError: gherkin/util/FixJava.Maybe that would be appropriate to create something like
cucumber-standaloneorcucumber-cliartefact which has all needed shaded artefacts/jars.