Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages when loading features from rerun file #749

Merged
merged 1 commit into from
Aug 29, 2014

Conversation

brasmusson
Copy link
Contributor

When feature file is not found on the file system, this will cause an IllegalArgumentException ("Not a file of directory"). However IllegalArgumentException can also occur for other reasons during the feature loading process, for instance for "Inconsistent filters" (more than one type from the tag, name, line filter types used).

This PR make a better job to distinguish between the exceptions that can occur when loading features based on a rerun file, in order to provide better error messages.

Distinguish between "feature path not found" exceptions and other
IllegalArgumentExceptions exceptions, when loading feature files
based on a rerun file.
aslakhellesoy added a commit that referenced this pull request Aug 29, 2014
Better error messages when loading features from rerun file
@aslakhellesoy aslakhellesoy merged commit e63ae0a into cucumber:master Aug 29, 2014
@brasmusson brasmusson deleted the rerun-file-error-messages branch August 29, 2014 13:30
@aslakhellesoy
Copy link
Contributor

Tack! @brasmusson !

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants