Add notes about Step class lifecycles #992
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://stackoverflow.com/a/33063300/8261 -- it is not at all obvious that Step classes (or their dependencies) are destroyed and re-created for each Scenario. This doc should hopefully make that clearer.
Since the Steps are destroyed & recreated for each Scenario, it is very important to clean up any resources allocated by them (e.g. database connections) otherwise projects with lots of Scenarios will grind to a halt with resource leaks. However, the Picocontainer lifecycle annotations for this are ignored by
cucumber-jvm
since it setsNullLifecycleStrategy
. I have added documentation here about the simplest workaround (@after annotations, which do work).HTH