-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Got ArgumentError
with unknown keyword in Ruby 3.4.0-preview2
#1769
Comments
This is fixed in |
Ref cucumber/cucumber-ruby#1769 v10 can be release in a very long time according to cucumber/cucumber-ruby#1759
Hello @luke-hill, |
9.2.1 with that commit, if it does not break, would be appreciated Additionally, it is worth to mention that the comment in a468bc6
feels outdated, since 3.4.0+ is not future anymore and can be improved. Copilot suggests
|
Would be really nice to get a point release with this fix published. Having to wait for cucumber 10 in order to use ruby 3.4 doesn't seem like a great solution, and I'd imagine that lots of people are going to be looking to upgrade to ruby 3.4 in the next few days/weeks/months. |
I opened #1773 to cherry-pick the ruby 3.4 fix into the 9.2 branch. Unfortunately tests are failing in the 9.2 release branch (an example run), so I'm not sure if this PR actually breaks anything for CI or not. It seems like the |
FWIW, using cucumber for |
If I get to see some more rockets / +1s I will prioritise this. Because (primarily my fault), we've got a mix of stuff in |
Until cucumber 10 is released there is an error: ```shell <internal:hash>:37:in 'initialize': unknown keywords: :strict, :proc (ArgumentError) ``` https://private-user-images.githubusercontent.com/1018543/390223151-53a9d969-a0c9-4391-8b1b-bd095db4f370.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzYyNTgxMjQsIm5iZiI6MTczNjI1NzgyNCwicGF0aCI6Ii8xMDE4NTQzLzM5MDIyMzE1MS01M2E5ZDk2OS1hMGM5LTQzOTEtOGIxYi1iZDA5NWRiNGYzNzAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDEwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAxMDdUMTM1MDI0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OWZkNzE1NjhlNmE1YTVjMTY2NjBiMjcxYWRhODU2N2JiMWZmMGMxNTZkZmMyNjM3NzA2ZWQ0ZWM3YTYzZmYyYiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.c7ho9LFAJ8TO1dnSocoRcaygKaXXVwPOqFv_GLiKAx8 This [issue](cucumber/cucumber-ruby#1769) covers the issue and mentions main is fixed. So can use that to unblock us?!
Until cucumber 10 is released there is an error: ```shell <internal:hash>:37:in 'initialize': unknown keywords: :strict, :proc (ArgumentError) ``` This [issue](cucumber/cucumber-ruby#1769) covers the issue and mentions main is fixed. So can use that to unblock us?!
π What did you see?
β What did you expect to see?
No error
π¦ Which tool/library version are you using?
ruby 3.4.0-preview2
cucumber-ruby 9.2.0
π¬ How could we reproduce it?
I run
bundle exec cucumber
but the following is easier:irb
Hash.new(strict: false).freeze
(simplified from https://github.com/cucumber/cucumber-ruby/blob/v9.2.0/lib/cucumber/multiline_argument/data_table.rb#L78)Ruby 3.3:
Ruby 3.4:
π Any additional context?
Trying to fix CI for ruby-head for https://github.com/egonSchiele/contracts.ruby
Update 1: Rubocop added a cop for this: https://docs.rubocop.org/rubocop/cops_lint.html#linthashnewwithkeywordargumentsasdefault
The text was updated successfully, but these errors were encountered: