Code

Refactor/remove multiple expects#1742

Code

Merged

luke-hill merged 15 commits intomaincucumber/cucumber-ruby:mainfrom refactor/remove_multiple_expectscucumber/cucumber-ruby:refactor/remove_multiple_expectsCopy head branch name to clipboardOct 3, 2023

+361-289

Commits

Commits on Oct 3, 2023

• For pretty spec remove all multiple expectation cop failures for snippet based tests

  luke-hill

  committed
  a24f2dd

  Copy full SHA for a24f2dd

• Linting tidy for pretty spec

  luke-hill

  committed
  b58c54c

  Copy full SHA for b58c54c

• Cleanup of file loading tests to ensure that tests only test one thing

  luke-hill

  committed
  ad167c6

  Copy full SHA for ad167c6

• Simplify test for multiple worlds

  luke-hill

  committed
  46f4b05

  Copy full SHA for 46f4b05

• Final tweaks to registry and more spec to resolve all specs only having 1 assertion

  luke-hill

  committed
  f9075d5

  Copy full SHA for f9075d5

• Remove all duplicate expectations from meta_message_builder

  luke-hill

  committed
  055c7e6

  Copy full SHA for 055c7e6

• Remove nearly all duplicate expect situations from options spec

  luke-hill

  committed
  7577731

  Copy full SHA for 7577731

• Stylistic tweaks to activate steps spec

  luke-hill

  committed
  6e560c9

  Copy full SHA for 6e560c9

• Remove double expectation wrappers on essentially allow calls for mocking

  luke-hill

  committed
  c5de765

  Copy full SHA for c5de765

• Remove all duplicate expectations from activate_steps spec

  luke-hill

  committed
  80faf5e

  Copy full SHA for 80faf5e

• Remove around 30% of multiple expectation offenses

  luke-hill

  committed
  e2ef6e6

  Copy full SHA for e2ef6e6

• Partial fix for maximum lets

  luke-hill

  committed
  3b6d99d

  Copy full SHA for 3b6d99d

• Fix up all RSpec/NestedGroups offenses

  luke-hill

  committed
  fcfd0e6

  Copy full SHA for fcfd0e6

• Fix up incorrect rubocop fix

  luke-hill

  committed
  d5a6137

  Copy full SHA for d5a6137

• Add in additional note about rubocop fixes

  luke-hill

  committed
  4a0998c

  Copy full SHA for 4a0998c