Skip to content

Commit

Permalink
build: Add mono and berp to docker (#1001)
Browse files Browse the repository at this point in the history
To make cucumber/common#771 possible we need both mono and berp. Currently mono isn't installed and berp is checked in as a binary executable. Both are less then ideal. 

Currently mono isn't supported on the same version of alpine as .NET Core SDK 2.2.2. To avoid messing around too much with APK which doesn't support mono yet I've changed the base image to `ubuntu:20.04`. This makes it easier to install mono.

Additionally we can now also use the node version manager to manage the node and npm versions. They'll be installed without the need for global permissions. This solves another long standing build headace.

The make file will now use `mono  /var/lib/berp/1.1.1/tools/net471/Berp.exe -g gherkin.berp` which is less out of the box then it was before, but the exact installation instructions for berp and mono can be found in the `Dockerfile`.
  • Loading branch information
mpkorstanje authored May 31, 2020
1 parent 5d0c616 commit d0819ec
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion go/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ dist/
dist_compressed/
*.bin
*.iml
core.*.!usr!bin!upx
# upx dist/cucumber-gherkin-openbsd-386 fails with a core dump
core.*.!usr!bin!upx-ucl

0 comments on commit d0819ec

Please sign in to comment.