Add .net 8 to test platforms (#158)

cucumber · Sep 7, 2023 · 30824f6 · 30824f6
1 parent 7631f0d
commit 30824f6
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 9 deletions.
diff --git a/.github/workflows/release-nuget.yaml b/.github/workflows/release-nuget.yaml
@@ -15,7 +15,7 @@ jobs:
       - name: Setup .NET
         uses: actions/setup-dotnet@v3
         with:
-          dotnet-version: 7.0.x
+          dotnet-version: 8.0.x
       - uses: cucumber/[email protected]
         with:
           nuget-api-key: ${{ secrets.NUGET_API_KEY }}

diff --git a/.github/workflows/test-dotnet.yml b/.github/workflows/test-dotnet.yml
@@ -19,15 +19,14 @@ on:
 jobs:
   test-dotnet:
     runs-on: ubuntu-latest
-
     steps:
-      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
+      - uses: actions/checkout@v4
       - uses: actions/setup-dotnet@v3
         with:
-          dotnet-version: | 
+          dotnet-version: |
             6.0.x
             7.0.x
-
+            8.0.x
       - run: dotnet test
         working-directory: dotnet
 

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
 
 ## [Unreleased]
 ### Changed
+- [.NET] Bump sdk to .net 8. Added .net 8 to test platforms.
 - [Go] Upgraded messages to v22
 - [Go] Improve performance - don't compile regex on matcher create
 - [Perl] Fix release packaging

diff --git a/dotnet/Gherkin.Specs/Gherkin.Specs.csproj b/dotnet/Gherkin.Specs/Gherkin.Specs.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFrameworks>net7.0;net6.0</TargetFrameworks>
+    <TargetFrameworks>net8.0;net7.0;net6.0</TargetFrameworks>
     <OutputType>Exe</OutputType>
     <StartupObject>Gherkin.Specs.CLI.Program</StartupObject>
   </PropertyGroup>
@@ -21,7 +21,4 @@
     <ProjectReference Include="..\Gherkin\Gherkin.csproj" />
   </ItemGroup>
 
-  <ItemGroup>
-    <Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />
-  </ItemGroup>
 </Project>