Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perl add administrativia #146

Merged
merged 4 commits into from
Aug 14, 2023
Merged

Perl add administrativia #146

merged 4 commits into from
Aug 14, 2023

Conversation

ehuelsmann
Copy link
Contributor

🤔 What's changed?

Fixed release procedure:

  • The packaging fails on the version range specified for "Cucumber::Messages"
  • The CHANGELOG.md didn't actually get packaged

Also updated the Cucumber::Messages minimum version to v22 (in line with Go update).

⚡️ What's your motivation?

I'd rather have the release procedure succeed :-)

🏷️ What kind of change is this?

🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

@ehuelsmann ehuelsmann requested a review from mpkorstanje August 14, 2023 13:18
@mpkorstanje
Copy link
Contributor

Looks like the PHP check style tooling just got an update. That's what causes PHP to fail.

Version ranges are highly unusual in the Perl world and need
recent tooling to be able to deal with them. Include these
minimum requirements in the generated output to fix the
packaging error.
@ehuelsmann ehuelsmann force-pushed the perl-add-administrativia branch from d9d2241 to da4f48d Compare August 14, 2023 16:53
@ehuelsmann
Copy link
Contributor Author

Rebased on fixed PHP.

@ehuelsmann ehuelsmann merged commit 102a06e into main Aug 14, 2023
@ehuelsmann ehuelsmann deleted the perl-add-administrativia branch August 14, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants