Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): change module name to match repo #77

Merged
merged 1 commit into from
Dec 27, 2022

Conversation

otrava7
Copy link

@otrava7 otrava7 commented Dec 23, 2022

🤔 What's changed?

This PR changes Go module name to match source repo.

⚡️ What's your motivation?

go mod tidy in a project with the repo as github.com/cucumber/gherkin/v26 fails with:

github.com/cucumber/gherkin/v26: module github.com/cucumber/gherkin@latest found (v26.0.1+incompatible), but does not contain package github.com/cucumber/gherkin/v26

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@mpkorstanje mpkorstanje self-assigned this Dec 23, 2022
@mpkorstanje
Copy link
Contributor

Note to self, before releasing fix cucumber/polyglot-release#91

@mpkorstanje mpkorstanje merged commit 9323979 into cucumber:main Dec 27, 2022
@aslakhellesoy
Copy link
Contributor

Hi @otrava7,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@mpkorstanje
Copy link
Contributor

Cheers. Fixed and released.

Lets hope it works this time.

@otrava7
Copy link
Author

otrava7 commented Jan 4, 2023

Hi @aslakhellesoy, thanks for extending the invite! I was on holiday over the past week and wasn't able to accept, so the invite expired. Could you send it again?

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Jan 4, 2023

@otrava7 unfortunately that was an automated comment. I've invited you manually.

@otrava7
Copy link
Author

otrava7 commented Jan 4, 2023

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants