java: Improve text trimming performance #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Precompiled trimming patterns for better performance and merged patterns for `trim()` method.
Inspired by the PHP version.
Added unreleased Fixed entry.
Corrected bad class name
mpkorstanje
reviewed
Dec 29, 2022
Missed the ".java" extension
corrected typo
mpkorstanje
reviewed
Jan 3, 2023
|
|
||
| public class StringUtilsTest { | ||
| private static final String WHITESPACE = "\u00A0 \t"; | ||
| private static final String CUCUMBER = "🥒"; |
mpkorstanje
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Precompiled the
Patternused in the utility methods.⚡️ What's your motivation?
Performance improvement (e.g.
StringUtils.trim()is more than 3 times faster).Fixes #84
🏷️ What kind of change is this?
📋 Checklist: