Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added run tests for Cucumber #214

Merged
merged 2 commits into from
Feb 8, 2020
Merged

Added run tests for Cucumber #214

merged 2 commits into from
Feb 8, 2020

Conversation

lonnblad
Copy link
Member

@lonnblad lonnblad commented Feb 7, 2020

  • Refactored existing run tests for progress and JUnit
  • Added run tests for Cucumber

@lonnblad lonnblad requested a review from mxygem February 7, 2020 21:04
Copy link
Member

@mxygem mxygem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lonnblad Thanks for the addition of the cucumber test, but I'm really not into that particular file being +4k lines. Would you be able to put that (and possibly the other outputs) into their own files as fixtures the tests can load, please?

Do you think you'd be able to run all three tests in the same file, too?

@lonnblad
Copy link
Member Author

lonnblad commented Feb 7, 2020

sure, do you want it in something like fixtures/cucumber_output.json and fixtures/junit_output.xml?

@lonnblad lonnblad requested a review from mxygem February 7, 2020 23:06
Copy link
Member

@mxygem mxygem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heyo, much nicer! 🎉

@mxygem mxygem merged commit 873daf7 into cucumber:master Feb 8, 2020
@aslakhellesoy
Copy link
Contributor

Hi @lonnblad,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants