Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] Initial Autofix Rubocop work #217

Merged
merged 22 commits into from
Apr 24, 2024

Conversation

luke-hill
Copy link
Contributor

🤔 What's changed?

A bunch of Layout autofix cops. Also a few other small limited Autofix cops.

I have also fixed 2 individual areas where the jsonschema was adding redundant lines/code smells

⚡️ What's your motivation?

Make the codebase rubocop compliant

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@luke-hill
Copy link
Contributor Author

NB: @chybz - Something was up here with a run that failed on cmake cmate update

It might be nothing, but maybe something to check / monitor: https://github.com/cucumber/messages/actions/runs/8817284910/job/24203303631?pr=217

It does look like it was just a flaky connection timeout (But the other 3 then all got auto cancelled too)

@chybz
Copy link
Contributor

chybz commented Apr 24, 2024

@luke-hill yeee thanks for the report. I fixed the exact same issue in gherkin end just forgot to fix it here also.

@luke-hill luke-hill closed this Apr 24, 2024
@luke-hill luke-hill reopened this Apr 24, 2024
@luke-hill luke-hill merged commit 3a3c605 into main Apr 24, 2024
27 checks passed
@luke-hill luke-hill deleted the refactor/rubocop_autogen_fixes_part1 branch April 24, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants