Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] Split messages files per message type #225

Merged
merged 128 commits into from
Jun 13, 2024
Merged

Conversation

luke-hill
Copy link
Contributor

🤔 What's changed?

Massively re-architect the way in which all message methods are extracted and generated using templates.

⚡️ What's your motivation?

Make them more similar to java / cpp
Conform to standard ruby guidelines
Helps work towards rubocop conformance (Unlocking further upgrades)

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • 💥 Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

luke-hill added 30 commits April 5, 2024 16:26
luke-hill added 28 commits May 30, 2024 15:12
@luke-hill luke-hill merged commit 556259d into main Jun 13, 2024
26 checks passed
@luke-hill luke-hill deleted the refactor/split_large_file branch June 13, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant