Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency rubocop-rspec to v3 #276

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 30, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rubocop-rspec (changelog) '~> 2.31.0' -> '~> 3.4.0' age adoption passing confidence

Release Notes

rubocop/rubocop-rspec (rubocop-rspec)

v3.4.0

Compare Source

  • Fix RSpec/SortMetadata cop to limit sorting to trailing metadata arguments. ([@​cbliard])
  • Replace RSpec/StringAsInstanceDoubleConstant with RSpec/VerifiedDoubleReference configured to only support constant class references. ([@​corsonknowles])
  • Fix RSpec/EmptyExampleGroup cop false positive when a simple conditional is used inside an iterator. ([@​lovro-bikic])

v3.3.0

Compare Source

  • Deprecate top_level_group? method from TopLevelGroup mixin as all of its callers were intentionally removed from Rubocop/RSpec. ([@​corsonknowles])
  • Fix false positive for RSpec/EmptyMetadata for splat kwargs. ([@​pirj])

v3.2.0

Compare Source

  • Fix RSpec/VoidExpect to only operate inside an example block. ([@​corsonknowles])
  • Change RSpec/ContextWording cop to always report an offense when both Prefixes and AllowedPatterns are empty. ([@​ydah])
  • Add support for and and or compound matchers to RSpec/ChangeByZero cop. ([@​ydah])

v3.1.0

Compare Source

  • Add RSpec/StringAsInstanceDoubleConstant to check for and correct strings used as instance_doubles. ([@​corsonknowles])
  • Fix false-positive for RSpec/UnspecifiedException when a method is literally named raise_exception. ([@​aarestad])
  • Fix false-positive for RSpec/UnspecifiedException when not_to raise_error is used within a block. ([@​aarestad], [@​G-Rath])

v3.0.5

Compare Source

  • Fix false-negative and error for RSpec/MetadataStyle when non-literal args are used in metadata in EnforceStyle: hash. ([@​cbliard])
  • Improve offense message for RSpec/IndexedLet. ([@​earlopain])

v3.0.4

Compare Source

  • Fix false-negative for UnspecifiedException when matcher is chained. ([@​r7kamura])

v3.0.3

Compare Source

  • Add support for Unicode RIGHT SINGLE QUOTATION MARK in RSpec/ExampleWording. ([@​jdufresne])
  • Suppress deprecation warning for RSpec/MultipleExpectations, RSpec/MultipleMemoizedHelpers, and RSpec/NestedGroups cops. ([@​koic])

v3.0.2

Compare Source

  • Fix wrong autocorrect for RSpec/ScatteredSetup when hook contains heredoc. ([@​earlopain])
  • Fix false negative for RSpec/PredicateMatcher when expectation contains custom failure message. ([@​earlopain])
  • Facilitate the 3.0 upgrade flow with proper extracted cop messages. ([@​jeppester])

v3.0.1

Compare Source

  • Bump RuboCop requirement to +1.61. ([@​ydah])

v3.0.0

Compare Source

  • Remove extracted cops in Capybara, FactoryBot and Rails departments. ([@​ydah])
  • Remove RuboCop::RSpec::Language::NodePattern. ([@​ydah])
  • Remove RSpec/FilePath cop. ([@​ydah])
  • Remove RSpec/Capybara/FeatureMethods cop. If you are using this cop, change it to use RSpec/Dialect. ([@​ydah])
  • Add new RSpec/MissingExpectationTargetMethod cop. ([@​krororo])
  • Fix an error for RSpec/ScatteredSetup when one of the hooks is an empty block. ([@​earlopain])

These previously pending cops are now enabled by default: RSpec/BeEmpty, RSpec/BeEq, RSpec/BeNil, RSpec/ChangeByZero, RSpec/ClassCheck, RSpec/ContainExactly, RSpec/DuplicatedMetadata, RSpec/EmptyMetadata, RSpec/EmptyOutput, RSpec/Eq, RSpec/ExcessiveDocstringSpacing, RSpec/ExpectInLet, RSpec/IdenticalEqualityAssertion, RSpec/IndexedLet, RSpec/IsExpectedSpecify, RSpec/MatchArray, RSpec/MetadataStyle, RSpec/NoExpectationExample, RSpec/PendingWithoutReason, RSpec/ReceiveMessages, RSpec/RedundantAround, RSpec/RedundantPredicateMatcher, RSpec/RemoveConst, RSpec/RepeatedSubjectCall, RSpec/SkipBlockInsideExample, RSpec/SortMetadata, RSpec/SpecFilePathFormat, RSpec/SpecFilePathSuffix, RSpec/SubjectDeclaration, RSpec/UndescriptiveLiteralsDescription, and RSpec/VerifiedDoubleReference.

Read more about how to upgrade in https://docs.rubocop.org/rubocop-rspec/upgrade_to_version\_3.html


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/rubocop-rspec-3.x branch from 3d28fc4 to ff51ec9 Compare January 30, 2025 20:23
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4ed7f02) to head (ff51ec9).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #276   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          200       200           
=========================================
  Hits           200       200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot force-pushed the renovate/rubocop-rspec-3.x branch from ff51ec9 to 41c525d Compare January 31, 2025 02:48
@renovate renovate bot force-pushed the renovate/rubocop-rspec-3.x branch from 41c525d to f2af4c1 Compare January 31, 2025 06:49
@luke-hill luke-hill merged commit f5301b2 into main Jan 31, 2025
76 checks passed
@luke-hill luke-hill deleted the renovate/rubocop-rspec-3.x branch January 31, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants