Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby]: Update conformance #133

Merged
merged 11 commits into from
Oct 13, 2023
Merged

[Ruby]: Update conformance #133

merged 11 commits into from
Oct 13, 2023

Conversation

luke-hill
Copy link
Contributor

🤔 What's changed?

Like one or two of the repos so far (And some more to come), the conformance of the ruby side of things has been let slide for 2+ years.

This PR is the first of 3 major releases planned for tag-expressions, whereby we'll progressively bump aggressively through the legacy ruby versions (Whilst simultaneously updating dev dependencies and according cucumber-ruby testing)

⚡️ What's your motivation?

Get things up to date, with as little friction as possible

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)
  • 💥 Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

Timings. When is this good to hit? This tends to be a repo with little to no changes coming, so mirroring up with other breaking change releases would be good.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@luke-hill luke-hill requested a review from ehuelsmann October 6, 2023 15:40
@luke-hill
Copy link
Contributor Author

@ehuelsmann tagged you for a review purely w.r.t. timings. I know you've landed a few things in recently.

If you have any medium sized things landing it would be good to land these simultaneously and cut a major revision. Happy to be guided by yourself on this. I'll be making a series of PR's here to try progressively update the deps here as we're like 7-8 years behind schedule.

@luke-hill
Copy link
Contributor Author

Confirmed with Erik offline this is good to merge. As/when we cut the next version it'll be v6

@luke-hill luke-hill merged commit 4a1f26b into main Oct 13, 2023
@luke-hill luke-hill deleted the feature/ruby_conformance branch October 13, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant