-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evalv3: "field not allowed" regression with definition fields #3491
Labels
Comments
This is related to this: #543 This behavior was proposed, but it should not be implemented by v3 yet or at all. |
Agreed. Even if we did want to do this soon, it should be as a separate experiment. We want to make the transition from v2 to v3 as smooth as possible first. |
cueckoo
pushed a commit
that referenced
this issue
Oct 11, 2024
To be immediately followed with fix. Issue #3491 Signed-off-by: Marcel van Lohuizen <[email protected]> Change-Id: I86d2bfaa20600956bd3118fce07f71d1c4bff9f5 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1202460 Unity-Result: CUE porcuepine <[email protected]> Reviewed-by: Daniel Martí <[email protected]> TryBot-Result: CUEcueckoo <[email protected]>
vanhtuan0409
pushed a commit
to anduintransaction/cue
that referenced
this issue
Oct 15, 2024
To be immediately followed with fix. Issue cue-lang#3491 Signed-off-by: Marcel van Lohuizen <[email protected]> Change-Id: I86d2bfaa20600956bd3118fce07f71d1c4bff9f5 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1202460 Unity-Result: CUE porcuepine <[email protected]> Reviewed-by: Daniel Martí <[email protected]> TryBot-Result: CUEcueckoo <[email protected]>
vanhtuan0409
pushed a commit
to anduintransaction/cue
that referenced
this issue
Oct 15, 2024
This was currently not always allowed due to an inconsistency in the logic. Issue cue-lang#543 Fixes cue-lang#3491 Signed-off-by: Marcel van Lohuizen <[email protected]> Change-Id: If5404d8adbe0ac13a665579e6d273722d54ef268 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1202461 Reviewed-by: Daniel Martí <[email protected]> TryBot-Result: CUEcueckoo <[email protected]> Unity-Result: CUE porcuepine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of 44cceca:
As far as I can tell, evalv2 is right in accepting this configuration. In fact, the error
config.#Extra: field not allowed
feels like it should be impossible; as far as my understanding of the spec goes, definitions and hidden fields should not be affected by closedness at all.The text was updated successfully, but these errors were encountered: