-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evalv3: index out of range panic in overlayContext.allocCC #3597
Comments
A somewhat simplified example (removed pattern constraint and such):
|
Noting that #3654 also triggers this under evalv3. |
A somewhat simplified reproducer:
|
cueckoo
pushed a commit
that referenced
this issue
Jan 9, 2025
assignConjunct returns an closeContext and a position at which a given conjunct was added in that closeContext. It assumed, however, that the conjunct was always added and that the index would always be the length of the Conjuncts. In reality, when check is enabled, it would look for duplicates and not add a conjunct when it already existed. This would cause the index to be misaligned. In practice this can only be a problem when creating overlays (with disjunctions). Still, it is surprising that this seemingly big bug did not break anything, even when it is hard to construct a test to reproduce it. We do expect this to explain why some of the optimization attempts earlier seemed buggy. We could try that again after this fix. Issue #3597 Signed-off-by: Marcel van Lohuizen <[email protected]> Change-Id: Idef4d16eab1150ded6d6210a27afc3d12fa8f0c5 Reviewed-on: https://gerrithub.io/c/cue-lang/cue/+/1206927 Unity-Result: CUE porcuepine <[email protected]> TryBot-Result: CUEcueckoo <[email protected]> Reviewed-by: Matthew Sackman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of c29fd02:
Reduced from https://github.com/vectordotdev/vector in Unity.
The text was updated successfully, but these errors were encountered: