Requests with credentials (add withCredentials to xhr)

[webpro]

How should I do an XHR/XDR that has withCredentials set to true? Basically I need it to send cookies along with the request (cookies were set server-side).

In plain JS I can do:

var xhr = new XMLHttpRequest();
xhr.withCredentials = true;

Here's what I tried with rest.js:

var myFirstInterceptor = interceptor({
    request: function handleRequest(request, config) {
        request.withCredentials = true;
        return request;
    }
});

var client = rest.chain(myFirstInterceptor);
client({path: '/foo'});

However, the request object here is not the "raw" XMLHTTPRequest, nor is the property copied onto the actual XHR object.

Can you help me out here? :-)

[scothis]

Right now there is no way to do what you're trying to do with rest.js. Although, it's easy enough to copy the withCredentials on to the actual xhr inside https://github.com/cujojs/rest/blob/master/client/xhr.js.

It's worth noting that only XHR2 compatible browsers know what to do with the property. rest.js doesn't somehow make an older browser handle CORS.

I'll add this before the next release

[webpro]

It's worth noting that only XHR2 compatible browsers know what to do with the property. rest.js doesn't somehow make an older browser handle CORS.

Sure, but still it should be possible, imho.

I'll add this before the next release

Thanks! Appreciated.

[scothis]

Trying to think through the best way to approach this. I think there are basically two options:

1. create a 'withCredentials' property on the rest.js request that is set on the XHR
2. create a 'mixins' object on the rest.js request that can contain any values that will be copied into the XHR

Option 1 is clearly specific to this need and only relevant to the XHR client. Option 2 has a chance of being applicable in other environments, and supporting other properties.

Thoughts @webpro ?

[webpro]

Definitely the 2nd option (there's plenty of attributes that can be set on the XHR(2) object). For what it's worth, that's also how jQuery does it.

[scothis]

@webpro I have a fix on the dev branch if you wouldn't mind giving it a spin. One curious bit is that adding any new property to the XHR object in IE 6 causes the assignment to throw. So I added a check that the property exists on the XHR object before doing the assignment.

[unscriptable]

haha, yah. in IE6, the xhr object is a "native" object, not a JavaScript object.

[scothis]

Fix is on the dev branch and will be part of the next release. Please reopen if this doesn't fit your needs.

[webpro]

Thanks a bunch, @scothis! Just tested with the dev branch and works great for me.