Code and comment fixes for stream #5243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmaehashi
force-pushed
the
stream-refactoring
branch
2 times, most recently
from
4ebfe5e to
9600338
Compare
kmaehashi
changed the title
kmaehashi
force-pushed
the
stream-refactoring
branch
from
9600338 to
145287b
Compare
kmaehashi
added
cat:code-fix
asi1024
approved these changes
May 25, 2021
|
Jenkins, test this please. |
leofang
approved these changes
May 25, 2021
Comment on lines
+423
to
+424
| # associated with the stream, it is way too complicated and does not | ||
| # work with HIP. Let us keep this as thin as possible. |
There was a problem hiding this comment.
This is referring to #5172 (comment). Thanks for adding it!
|
Yes, the original motivation of this refactoring was to improve weakref handling, but as weakref will be removed in #5251 this PR now became just a code cleanup 😅 |
|
Jenkins CI test (for commit 145287b, target branch master) failed with status FAILURE. |
|
pfnCI, test this please. |
|
Jenkins CI test (for commit 145287b, target branch master) succeeded! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.