Add special functions from the CUDA Math API #6317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In practice order is likely to be a very small integer, but it is annoying to users if they have to cast the first input to int32 rather than allowing the default Python int type.
|
I guess the |
|
This pull request is now in conflicts. Could you fix it @grlee77? 🙏 |
|
This pull request is now in conflicts. Could you fix it @grlee77? 🙏 |
|
/test mini |
|
Please test again (the prior failure in |
|
/test mini |
asi1024
approved these changes
Jan 30, 2022
|
LGTM! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR adding simple ufunc wrappers for a handful of other CUDA Math API functions that overlap with functions in
cupyx.scipy.special.One question:
scipy.special.sincisnumpy.sinc. This function promotes any integer dtype to double while the implementation here does not. For example, forcupy.sincas used here, providingcp.int8input will result in acp.float16array being returned. Should we make a wrapper that promotes any ints tocp.float64for consistency with SciPy?