Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps.edn alias overrides from ~/.clojure/deps.edn fail if they contain '/' #2161

Closed
raymcdermott opened this issue Apr 22, 2019 · 10 comments
Closed
Labels
bug Marks issues describing bugs released Marks issues which have had the fixes released in a stable build
Milestone

Comments

@raymcdermott
Copy link

This seems to be a regression as my old local override aliases worked fine.

Changing my/alias to my-alias works as a fix.

Cursive v1.8.1-2019.1
IntelliJ IDEA 2019.1 (Ultimate Edition)
Build #IU-191.6183.87, built on March 27, 2019
JRE: 1.8.0_202-release-1483-b39 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.14.4

@cursive-ide cursive-ide added this to the 1.8.2 milestone Apr 25, 2019
@cursive-ide
Copy link
Owner

When you say they fail, what do you mean?

@cursive-ide
Copy link
Owner

I've fixed one bug where there was a warning in the run config panel that the alias name isn't valid (but that would still let you do what you need to do), but I can't find anything else. Let me know if there are further problems here that need attention.

@raymcdermott
Copy link
Author

raymcdermott commented May 5, 2019 via email

@cursive-ide
Copy link
Owner

I can't reproduce that. I've managed to:

  1. Select the alias in the Clojure Deps toolwindow, and had the values take effect in the project sync.
  2. Add the alias to a run configuration, get it passed to deps and have it take effect.

Can you specify exactly what is failing for you?

@raymcdermott
Copy link
Author

raymcdermott commented May 6, 2019 via email

@cursive-ide cursive-ide modified the milestones: 1.8.2, 1.8.2-eap3 May 18, 2019
@raymcdermott
Copy link
Author

I'm experiencing this again
image

@raymcdermott
Copy link
Author

image

@raymcdermott
Copy link
Author

➜ java -version
openjdk version "1.8.0_222"
OpenJDK Runtime Environment (build 1.8.0_222-b05)
OpenJDK 64-Bit Server VM (build 25.222-b05, mixed mode)
➜ clojure
Clojure 1.10.1
user=>
image

@raymcdermott
Copy link
Author

image

@raymcdermott
Copy link
Author

the current project is Clojure

  • the project called sdk-data is CLJC
  • I'm using SSH for the git deps when they're not served through :local/root

@cursive-ide cursive-ide added the bug Marks issues describing bugs label Sep 22, 2020
@cursive-ide cursive-ide added the released Marks issues which have had the fixes released in a stable build label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Marks issues describing bugs released Marks issues which have had the fixes released in a stable build
Projects
None yet
Development

No branches or pull requests

3 participants