Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use multiline pairs for head/tail modifier. #2659

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Don't use multiline pairs for head/tail modifier. #2659

merged 5 commits into from
Sep 18, 2024

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Sep 8, 2024 •
edited
Loading

change tail did the wrong thing in this case

"""|foo
 bar
"""

Checklist

  • I have added tests
  • [/] I have updated the docs and cheatsheet
  • [/] I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson requested a review from a team as a code owner September 8, 2024 08:50
phillco
phillco approved these changes Sep 15, 2024
View reviewed changes
Copy link
Member

@phillco phillco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry I missed this.

...s/modifiers/scopeHandlers/SurroundingPairScopeHandler/SurroundingPairInteriorScopeHandler.ts Outdated Show resolved Hide resolved
@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Sep 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 18, 2024
@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 72c46b7 Sep 18, 2024
15 checks passed
@AndreasArvidsson AndreasArvidsson deleted the multilineTail branch September 18, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillco phillco phillco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreasArvidsson @phillco