Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev ex 202 self host google fonts #1149

Merged

Conversation

jerryh-jr
Copy link
Contributor

#202

Relevant issue number

Please check the following

  • Do the tests still pass? (see Run the Tests)
  • Is the code formatted properly? (see Linting (Formatting))
  • For New Features:
    • Have tests been added to cover any new features or fixes?
    • Has the documentation been updated accordingly?

Please describe additional details for testing this change

Checked multiple pages in dev vs production to verify fonts were being used correctly.

In the following screenshots dev environment is on the left and production is on the right.

Welcome Page

Rules Page

Game Finder Screen

Endgame Reveal Pop Up

Lobby Screen

Create Game Dialog

In-Game Screen

@jerryh-jr
Copy link
Contributor Author

jerryh-jr commented Jan 7, 2025

@seriouslysean and @itsalaidbacklife with adding the files to self host can you please check over how I formated the fonts directory and give any guidance on any changes that need to be made.

Also, with all of the font-face imports for the fonts do you believe it is best to leave it in the App.vue file or would it be better to move it out of it and into another file? If so can you provide guidance.

I used all of the font types from this url also including the Roboto ones from the head in the html file.

I added the license from each from the google download as well.

src/App.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@itsalaidbacklife itsalaidbacklife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerryh-jr well done; great work. Just pull the style contents out of App.vue and into src/sass/typography.scss and this is good to go

@itsalaidbacklife itsalaidbacklife added version-patch An update that warrants a bumping the project's patch version (e.g. 4.0.0 => 4.0.1) frontend Requires changes to the frontend (vue) client labels Jan 12, 2025
@itsalaidbacklife itsalaidbacklife merged commit e7211ca into cuttle-cards:main Jan 13, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Requires changes to the frontend (vue) client version-patch An update that warrants a bumping the project's patch version (e.g. 4.0.0 => 4.0.1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DevEx]: self-host Google Fonts
3 participants