-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev ex 202 self host google fonts #1149
Dev ex 202 self host google fonts #1149
Conversation
@seriouslysean and @itsalaidbacklife with adding the files to self host can you please check over how I formated the fonts directory and give any guidance on any changes that need to be made. Also, with all of the font-face imports for the fonts do you believe it is best to leave it in the App.vue file or would it be better to move it out of it and into another file? If so can you provide guidance. I used all of the font types from this url also including the Roboto ones from the head in the html file. I added the license from each from the google download as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerryh-jr well done; great work. Just pull the style contents out of App.vue and into src/sass/typography.scss and this is good to go
#202
Relevant issue number
Please check the following
Please describe additional details for testing this change
Checked multiple pages in dev vs production to verify fonts were being used correctly.
In the following screenshots dev environment is on the left and production is on the right.