improved documentation for component 'Semi-automatic and automatic an… #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yanmu2017 Thank you for the contribution! Could you fix a couple of minor comments and fix the linter issues? |
azhavoro
reviewed
Oct 9, 2020
| - [Run Nuclio dashboard with](https://github.com/nuclio/nuclio) | ||
|
|
||
| ```bash | ||
| docker run -p 8070:8070 -v /var/run/docker.sock:/var/run/docker.sock -v /tmp:/tmp --name nuclio-dashboard quay.io/nuclio/dashboard:stable-amd64 |
There was a problem hiding this comment.
I think it's unnecessary step, it's already configured here https://github.com/openvinotoolkit/cvat/blob/develop/components/serverless/docker-compose.serverless.yml#L4-L20
| Note: | ||
| - see [deploy.sh](/serverless/deploy.sh) script for more examples. | ||
| - As an example, if you use `nuctl-1.4.18-linux-amd64` in the CVAT root directory, | ||
| you need to change the `nuctl` in the above commands to `.nuctl-1.4.18-linux-amd64`. |
There was a problem hiding this comment.
Suggested change
| you need to change the `nuctl` in the above commands to `.nuctl-1.4.18-linux-amd64`. | |
| you need to change the `nuctl` in the above commands to `nuctl-1.4.18-linux-amd64`. |
nmanovic
reviewed
Oct 9, 2020
| Note: | ||
| - see [deploy.sh](/serverless/deploy.sh) script for more examples. | ||
| - As an example, if you use `nuctl-1.4.18-linux-amd64` in the CVAT root directory, | ||
| you need to change the `nuctl` in the above commands to `.nuctl-1.4.18-linux-amd64`. |
There was a problem hiding this comment.
Probably a better approach is to rename nuclt-* to nuctl or make a soft link ln nuctl-1.4.18-linux-amd64 nuctl
|
No reply from the contributor. I will close the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notes...
Motivation and context
I found some missing steps in the documentation of "Semi-automatic and automatic annotation".
As suggested by @azhavoro in issue isse 2245,
I prepared this PR.
How has this been tested?
I followed the steps in the new documentation on three machines and they all work.
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.