Cypress test. Object propagate. #2867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o dkru/case-53-propagate-not-on-last-frame
…o dkru/case-53-propagate-not-on-last-frame-origin
8 tasks
bsekachev
reviewed
Feb 25, 2021
| startPropagation(); | ||
| cy.get('.cvat-propagate-confirm-object-on-frames') | ||
| .find('input') | ||
| .should('have.attr', 'value', maxFrameNumber) |
There was a problem hiding this comment.
Let's remove this check. It is not actually true because default it set to 50.
There was a problem hiding this comment.
No problem. Done.
| startPropagation(); | ||
| cy.get('.cvat-propagate-confirm-object-on-frames') | ||
| .find('input') | ||
| .should('have.attr', 'value', propagateOnOneFrame) |
There was a problem hiding this comment.
The same. I do not see any necessity to check this value.
|
|
||
| it('From the 1st frame propagate again on 2 frames.', () => { | ||
| startPropagation(); | ||
| cy.get('.cvat-propagate-confirm-object-on-frames') |
There was a problem hiding this comment.
Can we do opposite thing in this test entering the value in cvat-propagate-confirm-object-up-to-frame? (and checking cvat-propagate-confirm-object-up-to-frame)
There was a problem hiding this comment.
Yes. I did this when propagate to 2 frames in the test.
…o dkru/case-53-propagate-not-on-last-frame-origin
bsekachev
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Add Cypress test.
How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.