Fixed showing annotations at 0 frame #7796
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
After the PR #7714 annotations are not loaded to the store with
GET_JOB_SUCCESS
action, instead we load them in separate async actionfetchAnnotationsAsync
.That leads to the problem:
CanvasWrapper
component is initially mounted with emptyannotations
array. That leads to such function calls:updateCanvas
->canvasInstance.setup
-> the promise is created that will set this.data.objects to empty array.Then the annotations are put to the store,
CanvasWrapper
runs update hook, where the chain is called again:updateCanvas
->canvasInstance.setup
-> but instead of promise, the objects are assigned right away. After that when the first promise will be executed the objects will be empty which leads to empty canvas wihout annotations.This PR fixes the problem by introducing
initialized
state status for annotations soCanvasWrapper
is not mounted before annotations are loaded. (+it removes one unnecessary re-render)How has this been tested?
Checklist
develop
branch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.