Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AdaLAM wrapper. #229

Merged
merged 7 commits into from
Sep 20, 2022
Merged

Added AdaLAM wrapper. #229

merged 7 commits into from
Sep 20, 2022

Conversation

mihaidusmanu
Copy link
Contributor

@mihaidusmanu mihaidusmanu commented Sep 2, 2022

Some results on South-Building

SIFT + MNN

    num_reg_images = 128
    num_cameras = 1
    num_points3D = 40544
    num_observations = 215421
    mean_track_length = 5.31326
    mean_observations_per_image = 1682.98
    mean_reprojection_error = 0.930621
    num_input_images = 128

SIFT + AdaLAM

   num_reg_images = 128
   num_cameras = 1
   num_points3D = 38752
   num_observations = 214480
   mean_track_length = 5.53468
   mean_observations_per_image = 1675.62
   mean_reprojection_error = 0.949959
   num_input_images = 128

Extra

  • Bugfix in GV if image has no keypoints

TODO

  • Add support for features without ori / scale (by setting orientation_difference_threshold and scale_rate_threshold to None)

@mihaidusmanu
Copy link
Contributor Author

@cavalli1234 for double checking

@mihaidusmanu mihaidusmanu removed the request for review from sarlinpe September 2, 2022 11:33
@mihaidusmanu mihaidusmanu marked this pull request as ready for review September 2, 2022 15:06
Copy link

@cavalli1234 cavalli1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good!

  • Just consider that, in case confidence might be useful, an estimate of it can be extracted from AdaLAM (in adalam/core.py, function adalam_core, variable conf). It is the ratio between the local inliers found divided by the expected number of random false positives you would get from outliers only in the same local neighborhood, so 1 means insignificant, and goes up unbounded.

@sarlinpe sarlinpe merged commit e566a8f into master Sep 20, 2022
@mihaidusmanu mihaidusmanu deleted the mihai/AdaLAM branch September 20, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants