Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move nanoflann to third-party and Fix typo. #115

Merged
merged 7 commits into from
Jan 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion limap/fitting/line3d_estimator.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ namespace fitting {

// Implements a simple solver that estimates a 3D line from two data points.
// Reference link:
// https://github.com/B1ueber2y/RansacLib/blob/master/examples/line_estimator.h
// https://github.com/tsattler/RansacLib/blob/master/examples/line_estimator.h
class Line3dEstimator {
public:
Line3dEstimator(const Eigen::Matrix3Xd &data);
Expand Down
1 change: 0 additions & 1 deletion limap/runners/functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@ def compute_2d_segs(cfg, imagecols, compute_descinfo=True):
cfg["line2d"]["detector"]["method"], imagecols.NumImages()
)
)
import limap.line2d

if not imagecols.IsUndistorted():
logging.warning("The input images are distorted!", stacklevel=2)
Expand Down
2 changes: 0 additions & 2 deletions limap/util/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ set(FOLDER_NAME "util")
LIMAP_ADD_SOURCES(
types.h
simple_logger.h simple_logger.cc

nanoflann.hpp
kd_tree.h kd_tree.cpp
)

1 change: 0 additions & 1 deletion limap/util/kd_tree.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#include <iostream>

#include "limap/util/kd_tree.h"
#include "limap/util/nanoflann.hpp"

namespace limap {

Expand Down
2 changes: 1 addition & 1 deletion limap/util/kd_tree.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
#include <memory>
#include <string.h>

#include "limap/util/nanoflann.hpp"
#include <Eigen/Core>
#include <third-party/nanoflann.hpp>

using namespace nanoflann;

Expand Down
File renamed without changes.
Loading