Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document minimum git version #216

Closed

Conversation

deviantintegral
Copy link

I was building on a server with Ubuntu 16.04 and it ships with git 1.9.1. In those cases, applying patches to non-git dependencies silently fails as no error message or exit code is returned by git apply.

This PR just updates the README; IMO it's probably too much complexity to parse git --version given the format of the string isn't stable.

@cweagans
Copy link
Owner

cweagans commented Jun 5, 2018

👍 good call. I think we're going to start moving in the direction of using patch for everything in the near future (just for the sake of predictable behavior), so hopefully this won't be a concern for too much longer.

@coveralls
Copy link

coveralls commented Jun 5, 2018

Coverage Status

Coverage decreased (-13.8%) to 24.449% when pulling d3b342f on deviantintegral:document-git-version into d3b9741 on cweagans:master.

@stucki
Copy link

stucki commented Jul 13, 2018

This should not be necessary anymore after merging #227.

@cweagans
Copy link
Owner

cweagans commented Feb 4, 2023

I've made a note to capture this and/or #227 in #447.

@cweagans cweagans closed this Feb 4, 2023
@cweagans cweagans mentioned this pull request Feb 7, 2023
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants