Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Retries to host factory request #32

Merged
merged 1 commit into from
May 28, 2020
Merged

Conversation

hughsaunders
Copy link
Contributor

Retries may be necessary if the conjur instance is busy, or if a
load balancer is updating.

Related: conjurinc/ops#596

@hughsaunders hughsaunders requested a review from a team as a code owner May 19, 2020 12:36
@izgeri
Copy link
Contributor

izgeri commented May 19, 2020

@hughsaunders can you add a changelog entry for this change please? it should describe the user impact and link to this PR (or preferably an issue, if there is one)

note that the links need to use the markdown link syntax, so they can be parsed later

eta it might be useful to describe some of the context that's in the private issue for what motivated this change in this PR. this project is public, but community users can't see the private issue to learn more about why we're making this change.

Retries may be necessary if the conjur instance is busy, or if a
load balancer is updating.

Related: conjurinc/ops#596
@hughsaunders
Copy link
Contributor Author

@izgeri added changelog entry

@hughsaunders hughsaunders merged commit 2114e54 into master May 28, 2020
@hughsaunders hughsaunders deleted the conjurinc-ops-596 branch May 28, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants