Update online go version #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jtuttle
previously approved these changes
May 15, 2019
| @@ -50,6 +50,13 @@ This will automatically update go.mod and go.sum. | |||
|
|
|||
| Commit your changes, and the next time `./package.sh` is run the `vendor/conjur-env` directory will be created with updated dependencies. | |||
|
|
|||
| When upgrading the version of Go for `conjur-env`, both the pre-built offline version and online version need to be | |||
There was a problem hiding this comment.
This is kind of unfortunate. Is there any way we can tie these together? Like maybe have a GO_VERSION file that they both source from and automatically get the hash somehow? Not sure if you can parameterize a Dockerfile like that but it might be worth considering.
There was a problem hiding this comment.
I'm not sure, but it's a good idea. I've created an issue to look into iterating on this here: #41
jtuttle
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to #39
This PR:
Updates the Go version for the online buildpack to
1.12.4(1.12.5is not yet from the CloudFoundry buildpacks repository).Fixes the integration tests to ensure the online buildpack is passing.
Updates
CONTRIBUTING.mdto include instructions for updating Go forconjur-env.