Bump version #74
Bump version #74
Conversation
test.sh
Outdated
| ARG="--tags" | ||
| INT="not @integration" |
There was a problem hiding this comment.
should these be set to empty vars if the code doesn't hit this path?
There was a problem hiding this comment.
The shell will disregard them if they aren't set, which they will not be if we don't hit this path.
In any case, there were more issues with string interpolation, so I modified the command.
BradleyBoutcher
force-pushed
the
bump-version
branch
2 times, most recently
from
c8be82b to
84ba4ff
Compare
test.sh
Outdated
| --out ./features/reports \ | ||
| ${INTEGRATION_TAG} | ||
| if [ -n "$CF_API_ENDPOINT" ]; then | ||
| # run tests against latest build of buildpack |
There was a problem hiding this comment.
this is 100% an ignorable nit but now you've capitalized one comment and I want it for all the others too
| # run tests against latest build of buildpack | |
| # Run tests against latest build of buildpack (including integration tests against remote foundation) |
There was a problem hiding this comment.
@BradleyBoutcher I still think it'd be helpful to add something like I suggested to the end of this line
(including integration tests against remote foundation)
to clarify that in this flow, we are also running those tests
There was a problem hiding this comment.
Ah thank you! I didn't see the rest of this change and only capitalized the letter. I'll commit this change 👍
BradleyBoutcher
force-pushed
the
bump-version
branch
2 times, most recently
from
1a6781d to
d955a61
Compare
- Small modification to test.sh syntax, as required by newer cucumber versions - Updated all gems to newer versions
Update Summon version in Notices.txt
BradleyBoutcher
force-pushed
the
bump-version
branch
from
d955a61 to
47c7c3c
Compare
What does this PR do?
world.rbto meet newer dependency requirementstest.shto work with newer versions of cucumberWhat ticket does this PR close?
Connected to #66
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or