Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix malformed mime type #82

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Fix malformed mime type #82

merged 2 commits into from
Mar 4, 2022

Conversation

szh
Copy link
Contributor

@szh szh commented Mar 4, 2022

Desired Outcome

Fix error

ActionDispatch::Http::MimeNegotiation::InvalidType ("text
plain" is not a valid MIME type)

Implemented Changes

  • Changed the "text\plain" (backslash) mime type to "text/plain" (forward slash)

Connected Issue/Story

CyberArk internal issue link: ONYX-17641

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@szh szh force-pushed the fix-mime-type branch from d0d76e4 to 052ab60 Compare March 4, 2022 15:03
@szh szh self-assigned this Mar 4, 2022
@szh szh added the kind/bug label Mar 4, 2022
@szh szh marked this pull request as ready for review March 4, 2022 15:06
@szh szh requested a review from a team as a code owner March 4, 2022 15:06
foxefj-cyber
foxefj-cyber previously approved these changes Mar 4, 2022
Copy link

@rpothier rpothier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants