Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Golang to 1.16 #117

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Update Golang to 1.16 #117

merged 1 commit into from
Nov 4, 2021

Conversation

szh
Copy link
Contributor

@szh szh commented Nov 3, 2021 •
edited
Loading

What does this PR do?

Go 1.15 is end of life. Update to 1.16.

What ticket does this PR close?

Resolves N/A

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

@szh szh marked this pull request as ready for review November 3, 2021 15:17
@szh szh requested a review from a team as a code owner November 3, 2021 15:17
@szh szh self-assigned this Nov 3, 2021
@szh szh requested a review from doodlesbykumbi November 3, 2021 15:18
diverdane
diverdane reviewed Nov 3, 2021
View reviewed changes
Copy link

@diverdane diverdane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, but I think we'll want a CHANGELOG.md entry in this special case, and we'll want to leave the version bump out for now until we're ready to do a release.

VERSION Outdated Show resolved Hide resolved
@szh szh requested a review from diverdane November 3, 2021 20:16
@szh szh merged commit 4e186a0 into main Nov 4, 2021
@szh szh deleted the update-golang branch November 4, 2021 15:41
@john-odonnell john-odonnell mentioned this pull request May 17, 2022
Merged
@gl-johnson gl-johnson mentioned this pull request Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlesbykumbi doodlesbykumbi doodlesbykumbi approved these changes

@diverdane diverdane Awaiting requested review from diverdane

Assignees

@szh szh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szh @doodlesbykumbi @diverdane